Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Unused client options manipulation #203

New issue
New issue
Open
Open
Unused client options manipulation#203
Labels
bug
@ctron

Description

@ctron
ctron
opened on Jun 9, 2021

In the constructor of the MQTT client, it looks like some changes in the past have changed the originally intended behavior:

vertx-mqtt/src/main/java/io/vertx/mqtt/impl/MqttClientImpl.java

Lines 156 to 165 in 9a91ad8

public MqttClientImpl(Vertx vertx, MqttClientOptions options) {
// copy given options
NetClientOptions netClientOptions = new NetClientOptions(options);
netClientOptions.setIdleTimeout(DEFAULT_IDLE_TIMEOUT);
this.vertx = (VertxInternal) vertx;
this.options = new MqttClientOptions(options);
this.keepAliveTimeout = ((options.getKeepAliveInterval() * 1000) * 3) / 2;
}

From what I see, the netClientOptions gets copied, manipulated, but then not used at all.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions