Incorporate new GFA parser + updated GFA spec #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master into dev branch.
avoid overly-cautious check
…en. Will hopefully be remedied by an update to gfakluge
… from erroneous GFA headers. Corrected an error in GFA writing in vg.cpp where version wasn't printed
Member
|
EDIT: I'm just going for it. Cheers. At the hackathon in Sendai we need to get a binary distributed, so I'm going to make a release (v1.4) and then a point release including this. |
ekg
added a commit
that referenced
this pull request
Feb 19, 2016
Incorporate new GFA parser + updated GFA spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated a few of the tests in the test suite to match the latest GFA spec. The previous md5sum values used a malformed header that looked like
H HVN:Z:1.0; it should (and now does) look likeH VN:Z:1.0.The new parser also: