Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Ensure additional components update on languagechange #8175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2023
Merged

fix: Ensure additional components update on languagechange #8175

merged 2 commits into from
Apr 4, 2023

Conversation

@mister-ben
Copy link
Contributor

@mister-ben mister-ben commented Mar 6, 2023

Description

Components should update their text on languagechange, but some weren't where they had behaviour other than that inherited from ClickableComponent

Specific Changes proposed

Added handleLanguagechange() behaviour for LoadingSpinner, SkipForward, SkipBackward, CaptionSettingsMenuItem, OffTextTrackMenuItem and TextTrackSettings

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@mister-ben mister-ben changed the title Fix languagechange fix: Ensure additional components update on languagechange Mar 6, 2023
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #8175 (8e9d776) into main (2a99a78) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8175      +/-   ##
==========================================
+ Coverage   82.08%   82.16%   +0.07%     
==========================================
  Files         112      112              
  Lines        7398     7417      +19     
  Branches     1782     1786       +4     
==========================================
+ Hits         6073     6094      +21     
+ Misses       1325     1323       -2
Impacted Files Coverage Δ
src/js/control-bar/skip-buttons/skip-backward.js 100.00% <100.00%> (ø)
src/js/control-bar/skip-buttons/skip-forward.js 100.00% <100.00%> (ø)
.../text-track-controls/caption-settings-menu-item.js 100.00% <100.00%> (ø)
...ar/text-track-controls/off-text-track-menu-item.js 100.00% <100.00%> (ø)
src/js/loading-spinner.js 100.00% <100.00%> (ø)
src/js/tracks/text-track-settings.js 95.41% <100.00%> (+0.07%) ⬆️
src/js/player.js 89.80% <0.00%> (+0.02%) ⬆️
src/js/component.js 93.31% <0.00%> (+0.22%) ⬆️
src/js/utils/browser.js 56.73% <0.00%> (+0.96%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@misteroneill misteroneill merged commit b489bc5 into videojs:main Apr 4, 2023
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
@mister-ben @edirub
fix: Ensure additional components update on languagechange (videojs#8175
7fb57b0 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@misteroneill misteroneill misteroneill approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mister-ben @misteroneill