Fix: src/3rdparty/libvterm: crash when out of memory while opening a terminal window #1326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out-of-memory more gracefully.
|
Hi @visualfc, thanks for merging my PR! Just wanted to let you know that I plan to report this as a CVE. Please let me know if you have any concern. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Development team,
I identified vulnerabilities in clone functions sourced from vim/vim. These issues, originally reported in CVE-2018-20786, were resolved in the Vim repository via this commit vim/vim@cd929f7.
This PR applies the corresponding patch to fix the vulnerabilities in this codebase.
Please review at your convenience. Thank you for your time and attention!