Cosmetic - nicer error when all hosts not connected to DVS #1647
Description
VIC Version:
0.1 / master / 3190
This is simply a request to see if we could make a nicer error/warning when some of the hosts in the cluster are not attached to the DVS, and thus do not have access to the bridge network (this is a deployment to a vCenter obviously)
Here is the error:
root@photon-NaTv5i8IA [ /workspace/vic ]# ./vic-machine-linux create --bridge-network Bridge-DPG --image-datastore vsanDatastore -t '[email protected]:[email protected]' --compute-resource Mgmt
INFO[2016-07-25T09:37:17Z] ### Installing VCH ####
INFO[2016-07-25T09:37:17Z] Generating certificate/key pair - private key in ./virtual-container-host-key.pem
INFO[2016-07-25T09:37:18Z] Validating supplied configuration
INFO[2016-07-25T09:37:18Z] Firewall status: ENABLED on "/CNA-DC/host/Mgmt/10.27.51.10"
INFO[2016-07-25T09:37:18Z] Firewall status: ENABLED on "/CNA-DC/host/Mgmt/10.27.51.8"
INFO[2016-07-25T09:37:18Z] Firewall status: ENABLED on "/CNA-DC/host/Mgmt/10.27.51.9"
INFO[2016-07-25T09:37:18Z] Firewall configuration OK on hosts:
INFO[2016-07-25T09:37:18Z] "/CNA-DC/host/Mgmt/10.27.51.10"
INFO[2016-07-25T09:37:18Z] "/CNA-DC/host/Mgmt/10.27.51.8"
INFO[2016-07-25T09:37:18Z] "/CNA-DC/host/Mgmt/10.27.51.9"
INFO[2016-07-25T09:37:18Z] License check OK on hosts:
INFO[2016-07-25T09:37:18Z] "/CNA-DC/host/Mgmt/10.27.51.10"
INFO[2016-07-25T09:37:18Z] "/CNA-DC/host/Mgmt/10.27.51.8"
INFO[2016-07-25T09:37:18Z] "/CNA-DC/host/Mgmt/10.27.51.9"
INFO[2016-07-25T09:37:18Z] DRS check OK on:
INFO[2016-07-25T09:37:18Z] "/CNA-DC/host/Mgmt/Resources"
INFO[2016-07-25T09:37:18Z] Creating virtual app "virtual-container-host"
INFO[2016-07-25T09:37:18Z] Creating appliance on target
INFO[2016-07-25T09:37:18Z] Network role "external" is sharing NIC with "management"
INFO[2016-07-25T09:37:18Z] Network role "client" is sharing NIC with "management"
ERRO[2016-07-25T09:37:20Z] Operation failed: A specified parameter was not correct: spec.deviceChange.device.port.switchUuid - (&{{} %!!(MISSING)s(*types.InvalidArgument=&{{{<nil> [{{} com.vmware.vim.vpxd.dvs.nonHostMember.label [{{} host 10.27.51.8} {{} dvs DSwitch}] Host 10.27.51.8 is not a member of VDS DSwitch}]}} spec.deviceChange.device.port.switchUuid}) A specified parameter was not correct: spec.deviceChange.device.port.switchUuid})
ERRO[2016-07-25T09:37:20Z] Unable to create appliance VM: Operation failed: A specified parameter was not correct: spec.deviceChange.device.port.switchUuid - (&{{} %!s(*types.InvalidArgument=&{{{<nil> [{{} com.vmware.vim.vpxd.dvs.nonHostMember.label [{{} host 10.27.51.8} {{} dvs DSwitch}] Host 10.27.51.8 is not a member of VDS DSwitch}]}} spec.deviceChange.device.port.switchUuid}) A specified parameter was not correct: spec.deviceChange.device.port.switchUuid})
INFO[2016-07-25T09:37:20Z] Collecting a0522635-224e-4171-92b1-7edaf726b39f vpxd.log
ERRO[2016-07-25T09:37:21Z] --------------------
ERRO[2016-07-25T09:37:21Z] vic-machine-linux failed: Creating the appliance failed with Operation failed: A specified parameter was not correct: spec.deviceChange.device.port.switchUuid - (&{{} %!s(*types.InvalidArgument=&{{{<nil> [{{} com.vmware.vim.vpxd.dvs.nonHostMember.label [{{} host 10.27.51.8} {{} dvs DSwitch}] Host 10.27.51.8 is not a member of VDS DSwitch}]}} spec.deviceChange.device.port.switchUuid}) A specified parameter was not correct: spec.deviceChange.device.port.switchUuid}). Exiting...
root@photon-NaTv5i8IA [ /workspace/vic ]#
Expected behavior:
Could we product a more human readable error? Even though all the information is in there, the output is not pretty.
Actual behavior:
As above.