Match TTML2 in what elements a src can reference #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@thomasheritage hopefully this addresses #312 - if you have time to check and confirm here that would be really helpful. |
|
Thanks @nigelmegitt -- yes, it looks like this resolves #312 |
Contributor
Author
@thomasheritage many thanks! |
cconcolato
approved these changes
Sep 23, 2025
c69428c to
b330956
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312 by making it that an
<audio>element'ssrcattribute must reference an<audio>element and a<source>element'ssrcattribute must reference a<data>element.Preview | Diff