Change netplan overlay to use netdev device names instead of the netdev name in bonds #2013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix needs to go into 01-netcfg.yaml, and I have tested it in the correct file and it does resolve this issue without affecting other functionality. |
|
@iankgt40 I don't see a |
|
Ah, 01-netcfg.yaml was the default config I was using based on netplan docs and testing/developing ... since I left it there, the "01" made it take precedence over the warewulf.yaml file in the actual lreased code. I tested remove 01-netcfg.yaml, rebuilt the overlays, and rebooted the node with everything built as expected.
So, ignore that part ... the patch tests correctly and performs as expected.Sorry I missed yesterdays meeting ... one of those few emergency Zooms ... I'm being pulled in so many directions, and the beginning of the school year is now. I listened to the recording, and I agree with Tim as far as getting building the deb into the Github pipeline (thogh I am not sure exactly how to do it). I'm not as keen as releasing it as a binary package though ... I think the dependeincies need to be verified and installed ...
Ian
Ian Kaufman
Principal Systems Integration Engineer
UC San Diego, Research IT Services
ikaufman AT ucsd DOT edu
…________________________________
From: Jonathon Anderson ***@***.***>
Sent: Thursday, September 18, 2025 8:44 AM
To: warewulf/warewulf ***@***.***>
Cc: Kaufman, Ian ***@***.***>; Mention ***@***.***>
Subject: Re: [warewulf/warewulf] Change netplan overlay to use netdev device names instead of the netdev name in bonds (PR #2013)
[https://avatars.githubusercontent.com/u/350294?s=20&v=4]anderbubble left a comment (warewulf/warewulf#2013)<https://urldefense.com/v3/__https://github.com/warewulf/warewulf/pull/2013*issuecomment-3308210013__;Iw!!Mih3wA!HsQVyjlrVrL3K_qMOWt5aWafstwUQU-NyJSFTYnraGAkSRDK8mKTzi6oxi7ldNBj5u5KV0UqbLQtTE2Lj3w3XHQp$>
@iankgt40<https://urldefense.com/v3/__https://github.com/iankgt40__;!!Mih3wA!HsQVyjlrVrL3K_qMOWt5aWafstwUQU-NyJSFTYnraGAkSRDK8mKTzi6oxi7ldNBj5u5KV0UqbLQtTE2Lj76I36n_$> I don't see a 01-netcfg.yaml in the overlay. Are you saying that it should be introduced in a new file? How do they differ? (I don't know much about netplan.)
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/warewulf/warewulf/pull/2013*issuecomment-3308210013__;Iw!!Mih3wA!HsQVyjlrVrL3K_qMOWt5aWafstwUQU-NyJSFTYnraGAkSRDK8mKTzi6oxi7ldNBj5u5KV0UqbLQtTE2Lj3w3XHQp$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AEWOCUNYYQAIXXKUSQ33OTD3TLHOJAVCNFSM6AAAAACGWACMF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMBYGIYTAMBRGM__;!!Mih3wA!HsQVyjlrVrL3K_qMOWt5aWafstwUQU-NyJSFTYnraGAkSRDK8mKTzi6oxi7ldNBj5u5KV0UqbLQtTE2Lj9LlvnxC$>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
…ev name in bonds Signed-off-by: Tim Weiers <[email protected]>
Signed-off-by: Jonathon Anderson <[email protected]>
06ca32f to
c600a3e
Compare
|
I updated the changelog and added testing for this case to the test suite. Just waiting for the tests to complete now. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue in the netplan overlay where bond interfaces were incorrectly using netdev names instead of device names, causing interfaces to not be properly added to bonds when the netdev name differs from the device name.
- Fixed bond creation logic to compare against device names instead of netdev names
- Updated interface addition to use device names rather than netdev names
- Added comprehensive test coverage for bond configurations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| overlays/netplan/rootfs/etc/netplan/warewulf.yaml.ww | Updated bond creation logic to use device names for proper interface matching |
| overlays/netplan/internal/netplan_test.go | Enhanced test suite with bond configuration scenarios and inline test data |
| CHANGELOG.md | Added entry documenting the bond device name fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
anderbubble
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
Currently the netplan overlay assumes that the device name and netdevs name of a network device are the same when creating bonds.
This can cause issues when the netdev name differences from the device name causing the overlay to skip adding the device to the bond.
For example.
A node has the following set:
NetDevs[default].Device: bond0
NetDevs[eth0].Device: eno12399np0
NetDevs[eth0].Tags[master]: bond0
NetDevs[eth1].Device: eno12409np1
NetDevs[eth1].Tags[master]: bond0
Before the if statement would check if the master tag matches the netdev name of the bond.
In this case that would fail as the device name is bond0 but the netdev name is default.
This would cause the interfaces to never get added.
Secondly when check was changed to look at device names instead the interace that would be added would be the netdev name instead of the device name.
This could cause issues with eth0 and eth1 getting added as interfaces but those interfaces don't exist and instead should be the netdev.device names eno12399np0 and eno12409np1.
This fixes or addresses the following GitHub issues:
Reviewer checklist
The reviewer checks the following items before merging the PR.
git commit --signoff) in agreement to the DCO