Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@welpo
Copy link
Owner

@welpo welpo commented Sep 1, 2024

Summary

Reduces the sizes of headers and lists on the main page to align with the sizing of single pages. This avoids overlapping text and too-large lists on the main landing page.

Related issue

Resolves #374.

Changes

  • Sets rem sizes for headers instead of em
  • Sets a size of 1rem for lists in the home banner.

Accessibility

Improved by avoding overlapping header text as well as properly sized list elements.

Screenshots

Before, on small screens or large text setups the header text would overlap when wrapped:

old

Now, headers and lists have the same size as they would in articles, avoiding overlapping text and too-large lists:

new

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@welpo welpo added the bug Something isn't working label Sep 1, 2024
@netlify
Copy link

netlify bot commented Sep 1, 2024

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit 48c3381
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/66d4ca6111512d00088cc846
😎 Deploy Preview https://deploy-preview-375--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@welpo welpo force-pushed the fix/main-page-styling-sizes branch from 750dc32 to 48c3381 Compare September 1, 2024 20:11
@welpo welpo merged commit 823e2ba into main Sep 1, 2024
@welpo welpo deleted the fix/main-page-styling-sizes branch September 1, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Content of h2 elements overlaps when wrapping on multiple lines

1 participant