Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🐛 fix: fix padding hover on links with code (custom font) #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

🐛 fix: fix padding hover on links with code (custom font) #494

merged 1 commit into from
Mar 12, 2025

Conversation

@clement-escolano
Copy link
Contributor

Summary

This fixes the design of a code with link when hovering.

Changes

Screenshots

Before:
image
After:
image

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have updated config.toml in tabi-start
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@clement-escolano clement-escolano requested a review from welpo as a code owner March 7, 2025 11:22
@netlify
Copy link

netlify bot commented Mar 7, 2025 •
edited
Loading

✅ Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit 26e5deb
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/67cad6ff8ef3390008cd265e
😎 Deploy Preview https://deploy-preview-494--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@welpo
Copy link
Owner

welpo commented Mar 8, 2025

Only way I could reproduce this was by setting --code-font to 'Source Serif', 'Georgia', serif;.

Is that something you configured on your skin, or am I missing something? I'd like to understand the issue before merging :)

@clement-escolano
Copy link
Contributor Author

Oh good catch and sorry for missing this! Indeed, I have a custom code font. If this is an edge case that you don't want to handle then I understand completely and you can close this PR :-)

@welpo welpo changed the title Fix design when hovering on a code with link 🐛 fix: fix padding hover on links with code (custom font) Mar 12, 2025
@welpo welpo added the bug Something isn't working label Mar 12, 2025
@welpo
Copy link
Owner

welpo commented Mar 12, 2025

Thanks!

@welpo welpo merged commit bf1d05e into welpo:main Mar 12, 2025
6 of 7 checks passed
This was referenced Mar 17, 2025
Merged
Merged
Open
Merged
Merged
Closed
This was referenced Mar 24, 2025
Open
Closed
This was referenced Mar 31, 2025
Open
Closed
Closed
Closed
Open
This was referenced Apr 7, 2025
Closed
Open
This was referenced Apr 14, 2025
Closed
Open
This was referenced Apr 21, 2025
Closed
Open
Closed
@github-actions github-actions bot mentioned this pull request May 1, 2025
Merged
This was referenced May 1, 2025
Merged
Open
Closed
This was referenced May 12, 2025
Open
Closed
This was referenced May 19, 2025
Open
Closed
Open
This was referenced May 26, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@welpo welpo Awaiting requested review from welpo welpo is a code owner

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clement-escolano @welpo