-
-
Notifications
You must be signed in to change notification settings - Fork 79
✨ feat: cache bust images in shortcodes #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for tabi-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thank you! Appreciate this PR. A few things:
What are your thoughts? |
|
I was also thinking of creating a theme-wide config option and/or a post-wide config option for this. I can't currently think of any reason to disable it either. |
Let's go with default = on + no way to disable it, until someone complains :) |
|
Thank you so much! |
cachebust parameter to image shortcodes|
I just noticed an issue with this. Images which cannot be found by Zola at the time of build don't work: |
|
Thanks for letting me know. I see this as a feature, no? Or is there a use-case I'm missing? |
I'm not sure. It was a real error from my side, and dynamic content will use |
Summary
Forces cache busting in image shortcodes.
Related issue
Brief discussion in #503
Changes
Accessibility
Screenshots
Type of change
Checklist
theme.tomlwith a sane default for the featureconfig.tomlin tabi-startconfig.tomlcommentstheme.tomlcomments