Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mmai
Copy link
Contributor

@mmai mmai commented Apr 5, 2025

Summary

This fixes missing html closing tags in hcard template

Related issue

#507

Changes

In partials/hcard.html:

  • Add closing div tag
  • replace set by set_global in for loop

Type of change

  • [x ] Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have updated config.toml in tabi-start
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@mmai mmai requested a review from welpo as a code owner April 5, 2025 20:22
@netlify
Copy link

netlify bot commented Apr 5, 2025

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit a7c92bc
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/67f190f8effe6f0008e12495
😎 Deploy Preview https://deploy-preview-508--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@welpo welpo merged commit 3d2c3a1 into welpo:main Apr 5, 2025
7 checks passed
@mmai mmai deleted the bugfix/hcardloop branch April 6, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants