⚠️ No Changeset found

Latest commit: 1c702ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Someone is attempting to deploy a commit to a Personal Account owned by @tmm on Vercel.

@tmm first needs to authorize it.

Nice! 🙌 I didn’t realize useResolver() was not doing the actual resolving.

There are a few issues with this hook structure that got addressed by this PR: #135

In summary:

• didCancel in the useEffect() doesn’t do anything (the condition will always be false since it happens right after the declaration) and can be safely removed.
• resolveName is not captured by the useEffect() dependencies, which means that the useEffect() wouldn’t react to a change of provider (returned by useProvider() and used by resolveName()).
• setState() is being called after an async operation (here and here) and will trigger warnings if the component has been rerendered / unmounted in the meantime. A didCancel flag (in a ref, outside of the useCallback()) would prevent this to happen.

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/zoo/wagmi/6n8iVRL3Vuihp7efdHw8urY7qYZ4
✅ Preview: https://wagmi-git-fork-shunkakinoki-feat-ini-resolve-name-zoo.vercel.app

thanks @shunkakinoki! was meaning to add this one.

@bpierre made the updates from your comment.

resolveName is not captured by the useEffect() dependencies, which means that the useEffect() wouldn’t react to a change of provider (returned by useProvider() and used by resolveName()).

Used cacheBuster instead since it's further upsteam dep of provider. Also, update a few other hooks to use it. Another reason I didn't add actions to the useEffect deps was because I noticed a lot of unnecessary requests triggered when testing.