feat: implement logical clock #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
af4d2a6 to
ceeebdf
Compare
Previously, the benchmark runner uses physical time to track the benchmark progress. This is not ideal because the physical time keeps moving forward even when the benchmark is paused. Also the throughput calculation is not accurate when there are pauses. This commit introduces a logical clock that can be paused and resumed to improve the pause functionality. Signed-off-by: Wenxuan Zhang <[email protected]>
Signed-off-by: Wenxuan Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the benchmark runner uses physical time to track the benchmark progress. This is not ideal because the physical time keeps moving forward even when the benchmark is paused. Also the throughput calculation is not accurate when there are pauses. This commit introduces a logical clock that can be paused and resumed to improve the pause functionality.