Removing link rel=serviceworker for now. #3233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is being removed as part of foreign fetch, but we may add it again once we have a better understanding of the use cases.
Member
|
This looks like a rough reversal of c5d4f5c (we should mention that in the final commit message I think). @sideshowbarker can you take a look since you added this? |
sideshowbarker
approved these changes
Nov 22, 2017
Member
|
Are there tests that need to be removed? Anything to reference in the commit message other than w3c/ServiceWorker#1207? |
Member
|
Perhaps we need a negative test or was this never implemented anywhere? |
Collaborator
Author
|
I removed the tests in web-platform-tests/wpt#7762. Do we usually do negative tests for things like this? It's in Chrome but behind a flag. |
jakearchibald
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 22, 2017
Member
|
It depends a bit on how long it's been around. If it's only behind a flag we probably don't need any. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is being removed as part of foreign fetch, but we may add it again once we have a better understanding of the use cases.