Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: millermedeiros/Hasher
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: winzig/Hasher
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 4 files changed
  • 1 contributor

Commits on Feb 16, 2013

  1. Prevent _trimHash from accidentally removing $ 

    If hasher.appendHash was not set to anything, the regular expression
being used by _trimHash would end up escaping the dollar-sign, which was
intended to be the "end of line" regular expression. This  was causing
dollar signs to be removing from hashes. The fix: Rather than always
inserting a \\ escape sequence before the prependHash and appendHash
variables, I pass them into a new private function called _escapeRegExp,
which will return an empty string if the input string is empty. This way
the resulting regex will not end up escaping the wrong thing when
appendHash is empty. In addition, if prependHash or appendHash was more
than one character long, this new escape function can handle escaping
more than one special character, so that it's future proof.
    @winzig
    winzig committed Feb 16, 2013
    Configuration menu
    Copy the full SHA
    a4cabcf View commit details
    Browse the repository at this point in the history
Loading