Move GNUInstallDirs include to before the target include directories #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job. But what's the archive.tar.gz? |
|
Whoops! Was just a source archive for hunter. Removed |
|
Can I get a release soon :) |
|
I tested the PR, it works properly. |
|
I need a .tar.gz hosted to add to Hunter yes, a GitHub release is the best way. Either bump the patch version and do a release in main or do a release in a fork :) |
|
I create a release. Let me know if it works. And after you add it to hunter, you may update the readme or give me the instruction on how to use eventpp with hunter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some investigation this is the correct solution for the #42 PR.
The GNUInstallDirs module was loaded AFTER the use of the
CMAKE_INSTALL_INCLUDEDIRThis meant it was not being evaluated correctly. This reordering resolves that.