Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@vasil1729
Copy link
Contributor

@vasil1729 vasil1729 commented Mar 25, 2025

Pull Request Description

Changes Made

  • Feature addition
  • Bug fix
  • Performance improvement
  • Refactoring
  • Documentation update
  • Other (please specify)

Description

  • Create a reminder.
  • Update a reminder.
  • Delete a reminder.
  • Index a reminder.
  • Add auto reminder on mark as complete for document,
  • Background job to periodically send reminder to the user via in app or email.

Why is this change required? What problem does it solve?

  • It would be possible to manage reminder based on the contract document expiry date.
  • User will be notified in app as well as email.

How Has This Been Tested?

  • Tested via API
  • Tested the periodic background job monitoring via oban job.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My changes generate no new warnings.
  • I have checked my code and corrected any misspellings.

@vasil1729 vasil1729 added the enhancement Improvements to existing features label Mar 25, 2025
@vasil1729 vasil1729 self-assigned this Mar 25, 2025
@vasil1729 vasil1729 changed the title Feat/clm expiry and remainder feat/clm expiry and remainder Mar 25, 2025
@vasil1729 vasil1729 changed the title feat/clm expiry and remainder feat: clm expiry and remainder Mar 25, 2025
@vasil1729 vasil1729 merged commit 13f16ed into main Mar 28, 2025
1 check passed
@vasil1729 vasil1729 deleted the feat/clm-expiry-and-remainder branch March 28, 2025 12:54
vasil1729 added a commit that referenced this pull request Apr 3, 2025
* chore : inital setup

* feat: created a genserver that handles the event trigger on expiry or reminder and would fire a notification to the shell

* feat: added functions to set expiry or reminders via redis

* feat: add basic crud apis for handling reminder

* feat: added valkey server, background scheduled job and sending notifications

* feat: added updates to valkey

* fix: minor fixes

* docs: add spec for delete API

* fix: add notification message for in app notification reminder

* fix: minor document reminder message restructuring

* fix: added fix to ensure that the oban jobs stuck in executing phase on system or db restarted or crash are not left out as orphans and are moved to available

* chore: remove valkey related code

* feat: add email template for reminder

* feat: add auto reminder on mark as complete for the document

* chore: minor fix

* chore: revert mix lock

* feat: add check for contract type document if the reminder is before the expiry date

* feat: add filters and sorting to reminder indexing

* feat: improve the email template

* fix: minor fix

* fix: on save of instance if the data is not updated , it returns error not found, instead just seamsly allow the user to click the save button

* fix: change update_meta api from post to put

* fix: remove the meta field from the params for meta update api

* feat: add filter for document index by upcoming and expired as well as sorting by expiry date asc and desc

* feat: ensure that the document filtering based on status upcoming/expired is only filtering those documents which are marked as complete

* fix: remove permissions for reminder controller actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvements to existing features

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants