-
Notifications
You must be signed in to change notification settings - Fork 21
feat: clm expiry and remainder #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reminder and would fire a notification to the shell
…on system or db restarted or crash are not left out as orphans and are moved to available
…r not found, instead just seamsly allow the user to click the save button
…s sorting by expiry date asc and desc
…ired is only filtering those documents which are marked as complete
salsabeeljamal
approved these changes
Mar 28, 2025
vasil1729
added a commit
that referenced
this pull request
Apr 3, 2025
* chore : inital setup * feat: created a genserver that handles the event trigger on expiry or reminder and would fire a notification to the shell * feat: added functions to set expiry or reminders via redis * feat: add basic crud apis for handling reminder * feat: added valkey server, background scheduled job and sending notifications * feat: added updates to valkey * fix: minor fixes * docs: add spec for delete API * fix: add notification message for in app notification reminder * fix: minor document reminder message restructuring * fix: added fix to ensure that the oban jobs stuck in executing phase on system or db restarted or crash are not left out as orphans and are moved to available * chore: remove valkey related code * feat: add email template for reminder * feat: add auto reminder on mark as complete for the document * chore: minor fix * chore: revert mix lock * feat: add check for contract type document if the reminder is before the expiry date * feat: add filters and sorting to reminder indexing * feat: improve the email template * fix: minor fix * fix: on save of instance if the data is not updated , it returns error not found, instead just seamsly allow the user to click the save button * fix: change update_meta api from post to put * fix: remove the meta field from the params for meta update api * feat: add filter for document index by upcoming and expired as well as sorting by expiry date asc and desc * feat: ensure that the document filtering based on status upcoming/expired is only filtering those documents which are marked as complete * fix: remove permissions for reminder controller actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Changes Made
Description
Why is this change required? What problem does it solve?
How Has This Been Tested?
Types of changes
Checklist: