[webOS] Audio sink improvements #23295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we set the queue and source buffer each to 8 * frameSize the cache was returning a too small duration
This was just really a magic number and it seems it's not needed anymore with the cache size fix
This is intended for game mode and seems to make things worse and disables some TV processing features
We should only increase the audio pts when the packet was fully consumed by the sink. With the first feed we don't increase pts because we want the pipeline to start at timestamp 0
We assume the channel count here because the information from AEStreamInfo is incorrect. This is probably correct for a lot of files and additionally it seems that the pipeline is fine with a wrong channel count (this might only be true for certain devices, because there is probably a reason for why the pipeline wants this information) We are also missing out on the EAC3-JOC information for the pipeline.
The field m_ac3FrameSize was never updated with the concatenated value of the independent and dependent substream
7 tasks
Contributor
|
Can confirm EAC-3 is working and A/V sync appears improved following this PR. |
Contributor
fritsch
approved these changes
May 25, 2023
Member
fritsch
left a comment
There was a problem hiding this comment.
Thanks much. The delay calculation of the sink itself still looks like a bit of guess work ;-). But yeah, most likely not possible to get that 100% right.
Thanks for the AEStreamInfo change, makes sense.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a couple of issues with Starfish sink
Fixes #23288
Motivation and context
As reported in #23288 E-AC3 was broken. It also fixes a couple of A/V sync problems that had to be tackled for proper E-AC3 support
How has this been tested?
OLED77C28LB / webOS 7/22
What is the effect on users?
Screenshots (if appropriate):
Types of change
Checklist: