Modify rflash to make sure BMC ready code 00 stays on for a while #2807
Conversation
|
Thanks @gurevichmark , looks good to me. |
| my $sessdata = shift; | ||
| my $ret; | ||
| my $ipmitool_ver; | ||
| my $verbose = 0; |
There was a problem hiding this comment.
@gurevichmark the way this is written. We won't check the verbose option until before the hpm upgrade step so the first call to check ready status after mc reset cold will have verbose level of 0, regardless of whether -V was passed in, correct?
| for my $opt (@{$sessdata->{'extraargs'}}) { | ||
| if ($opt =~ /-V{1,4}/) { | ||
| $cmd .= lc($opt); | ||
| $verbose = 1; |
There was a problem hiding this comment.
I think this setting here will not take effect on the other calls above for check_bmc_status_with_ipmitool(), we might want to have a similar check earlier in the code path to build up the verbose option. Does the -vvvv need to be passed to ipmitool at the end?
Looks like we can also search the extraargs for things like --buffersize=XXXXXX to control overriding the buffersize since this seems to come into play the last few days...
|
The modification looks good, @gurevichmark, thx very much! |
Helps resolve #2706
Under certain conditions we can get a transient
00BMC ready code before BMC starts rebooting itself.This pull request makes sure BMC
00ready code stays on for a little more than one minute before assuming that BMC is ready.-Vflag will display additional debugging information while waiting for BMC to be ready: