Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Dependent metric equality is fragile on new ProtocolMetricImpl #1236

@michael-mclawhorn

Description

@michael-mclawhorn

1st- The static reference to this.dependentMetrics can be overshadowed in suprising ways in subclasses through the static inclusion.
2nd - Equality on dependent metrics is so strict as to be problematic for testing and any kind of proxying. It should be sufficient to note that the dependent metric names are identical strongly indicating the same meaning with less test burden.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions