resolve TempDir paths before passing them to the flake bin #233
Conversation
|
Regarding the CI test failures: These are also present on |
| // automatically, which would involve checking parent directories | ||
| // for a git repository. | ||
| let uri = format!("path:{}", temp_dir.path().to_str().unwrap()); | ||
| let uri = format!( |
There was a problem hiding this comment.
Not sure if those are relevant, but my thinking was that it might resolve other future regressions.
There was a problem hiding this comment.
I did this near the point where the data (the temp path) leaves our control as this isn't a bug in the Rust side of things but at the boundary to a different system.
This only affects paths that we pass to nix (so ideally we would canonicalize the paths in FlakeMetadata::resolve). We could do that by passing something like a FlakePath to that function instead of the str.
enum FlakePath<'s> {
Path(&'s Path),
Git(&'s str)
}
<Display impl that canonicalizes before creating the `path:{}` string>This would allow us to keep the simple temp dir paths in places where it could get debug printed without causing any irritation why the tmp dir looks weird. The symlinks for tempdirs on macos are an implementation detail and should not be exposed in level-1 debug output (such as a dbg!()) print, IMHO.
On MacOS /tmp is a symlink to /private/tmp. TempDir creates a dir and returns the path as /tmp. nix is unhappy with symlink dirs when calling nix flake metadata --json To fix this we canonicalize the path first, resolving any symlinks on the way. Fixes zhaofengli#190.
815328f to
00fd486
Compare
Sadly it breaks CI in fork-originated PRs if the author doesn't enable Actions on the fork itself. This reverts commit ce1aa41.
On macOS
/tmpis a symlink to/private/tmp.TempDir creates a dir and returns the path as
/tmp/.... nix is unhappy with symlink dirs when callingnix flake metadata --json path:...To fix this we canonicalize the path first, resolving any symlinks on the way.