Replies: 3 comments 4 replies
-
|
The manufacturer ID and image type are used. They should be unique per device. However, we're currently working on a soon-to-be-released Zigbee firmware index for use in zigpy. There, you can then easily submit OTA images with model info to limit them per model name as well. EDIT: See puddly's comment below. For remote indexes, additional metadata can already be provided. |
Beta Was this translation helpful? Give feedback.
-
|
According to what you said, can I understand that the "modelId" field in the JSON content shown in the current screenshot is actually not effective? |
Beta Was this translation helpful? Give feedback.
-
|
OTA images are matched using:
Devices send something like this: QueryNextImageCommand(..., manufacturer_code=4098, image_type=5634, current_file_version=66)So only images for RemoteOtaImageMetadata(
file_version=76,
manufacturer_id=4659,
image_type=54183,
checksum=None,
file_size=None,
manufacturer_names=(),
model_names=('3RSB015BZ',),
changelog=None,
release_notes=None,
min_hardware_version=None,
max_hardware_version=None,
min_current_file_version=None,
max_current_file_version=None,
specificity=None,
source='ThirdReality',
url='https://tr-zha.s3.amazonaws.com/firmware/SmartCurtain_PROD_OTA_V76_v1.00.76.ota',
ssl_ctx=None,
),So even if Can you provide more information about what devices you're referring to (ZHA diagnostics of both would be useful)? Do they have the same model number and |
Beta Was this translation helpful? Give feedback.
-
|
Hello, as shown in the screenshot, the JSON content I am currently providing regarding OTA includes "modelId", "url", "version", "imageType", "manufacturerId", and "fileVersion". Does it mean that only "manufacturerId", "imageType" and "fileVersion" are effective? |
Beta Was this translation helpful? Give feedback.
-
|
No, we are very careful with OTA. We use async def test_ota_matching_thirdreality_test() -> None:
# 3RSPU01080Z checks in (UK variant)
device = make_device(model="3RSPU01080Z", manufacturer_id=5127)
query_cmd = Ota.ServerCommandDefs.query_next_image.schema(
field_control=FieldControl.HARDWARE_VERSIONS_PRESENT,
manufacturer_code=5127,
image_type=54196,
current_file_version=10,
hardware_version=1,
)
from zigpy.ota.providers import ThirdReality, RemoteOtaImageMetadata
index = await ThirdReality().load_index()
uk_plug_meta = next(i for i in index if i.image_type == 54196)
# US variant is missing right now but we can add it back in for testing
us_plug_meta = RemoteOtaImageMetadata(
file_version=43, # bigger version than UK
manufacturer_id=5127,
image_type=54196,
manufacturer_names=(),
model_names=("3RSP02064Z",),
source="ThirdReality",
url="https://tr-zha.s3.amazonaws.com/firmware/bl702_plug_gen3_usa_v1.00.43.ota",
)
index.append(us_plug_meta)
ota = zigpy.ota.OTA(config={config.CONF_OTA_ENABLED: False}, application=None)
ota.register_provider(SelfContainedProvider(index))
# Fetch the OTA images compatible with 3RSPU01080Z
images = await ota.get_ota_images(device, query_cmd)
# There is only one and it's the UK firmware
assert len(images.upgrades) == 1
assert images.upgrades[0].firmware == await uk_plug_meta.fetch()The ONLY way I can see this happening is if somebody manually downloaded the raw zha:
zigpy_config:
ota:
extra_providers:
- type: advanced # !!! Please read the message below before enabling OTA updates from raw OTA files !!!
warning: I understand I can *destroy* my devices by enabling OTA updates from
files. Some OTA updates can be mistakenly applied to the wrong
device, breaking it. I am consciously using this at my own risk.
path: /path/to/folder/of/otasI just checked the remote Z2M index that we support and the test passes there as well. |
Beta Was this translation helpful? Give feedback.
-
|
OK. Thank you for your patient explanation. I'll be studying it further. |
Beta Was this translation helpful? Give feedback.
-
|
Hi @hwzolin @weihuan1111, and @3reality-support! We're trying to move towards a central approach, as it's easier for most manufacturers, allows us to get feedback on the installed OTAs, do a quick sanity check for new updates, and have a "beta" zigpy-ota release channel to which we can (temporarily) limit new updates to. The repo doesn't require any PRs nor JSON metadata to add images. You can submit an issue (per image) with your existing OTA image URL and a PR will be auto-created and merged by us. Providing release notes is also simple and we've found that to be really helpful for users who are unsure about installing updates, so it's very much encouraged to just add a bit of the text about the particular update in that section of the issue form. If you want to limit the update to certain device models (e.g. like here), or to users who configured the zigpy-ota beta channel, or if you want to require a minimum installed existing version on the device, you can also add a bit of optional metadata. See the placeholder and examples in the issue form and README for that. We're also here to answer any questions. If any update later needs to be removed, you can submit a PR to edit the YAML text file per image and just add Also note that the ThirdReality |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
@puddly
Hello,
Recently, our company has two PLUG products. One is for the British standard, and the other is for the American standard.
However, during the ZHA OTA process, we discovered that the British standard PLUG was being OTA-ed onto the American standard.
I have a question right now: When ZHA was conducting the OTA testing of the equipment, what value was used as the criterion for differentiating between different devices? Is it the Product ID?
Beta Was this translation helpful? Give feedback.
All reactions