From 6ac64c1cd304cc279a6f88892caca2412703c29e Mon Sep 17 00:00:00 2001 From: Adam Fraser Date: Mon, 27 Feb 2023 22:26:11 -0800 Subject: [PATCH 1/2] delete flaky test --- .../test/scala/zio/metrics/MetricSpec.scala | 25 ------------------- 1 file changed, 25 deletions(-) diff --git a/core-tests/shared/src/test/scala/zio/metrics/MetricSpec.scala b/core-tests/shared/src/test/scala/zio/metrics/MetricSpec.scala index 9bd03a615074..b1ef2daa0b5a 100644 --- a/core-tests/shared/src/test/scala/zio/metrics/MetricSpec.scala +++ b/core-tests/shared/src/test/scala/zio/metrics/MetricSpec.scala @@ -179,31 +179,6 @@ object MetricSpec extends ZIOBaseSpec { state <- h.value } yield assertTrue(state.count == 2L, state.sum == 4.0, state.min == 1.0, state.max == 3.0) }, - test("observeDurations") { - val h = - Metric - .histogram("h3", Histogram.Boundaries.linear(0, 1.0, 10)) - .tagged(labels1) - .contramap[Duration](_.toMillis.toDouble / 1000.0) - - for { - // NOTE: observeDurations always uses real clock - start <- ZIO.attempt(java.lang.System.nanoTime()) - _ <- (Clock.sleep(1.second) @@ h.trackDuration) - _ <- (Clock.sleep(3.seconds) @@ h.trackDuration) - end <- ZIO.attempt(java.lang.System.nanoTime()) - elapsed = (end - start) / 1e9 - state <- h.value - } yield assertTrue( - state.count == 2L, - state.sum > 3.9, - state.sum <= elapsed, - state.min >= 1.0, - state.min < state.max, - state.max >= 3.0, - state.max < elapsed - ) - } @@ withLiveClock @@ flaky, test("observeHistogram") { val h = Metric .histogram("h4", Histogram.Boundaries.linear(0, 1.0, 10)) From ba393313f63333d6cbe7b3041df0d04767cb731a Mon Sep 17 00:00:00 2001 From: Adam Fraser Date: Mon, 27 Feb 2023 22:33:52 -0800 Subject: [PATCH 2/2] remove unused import --- core-tests/shared/src/test/scala/zio/metrics/MetricSpec.scala | 1 - 1 file changed, 1 deletion(-) diff --git a/core-tests/shared/src/test/scala/zio/metrics/MetricSpec.scala b/core-tests/shared/src/test/scala/zio/metrics/MetricSpec.scala index b1ef2daa0b5a..b650ed83c0d5 100644 --- a/core-tests/shared/src/test/scala/zio/metrics/MetricSpec.scala +++ b/core-tests/shared/src/test/scala/zio/metrics/MetricSpec.scala @@ -4,7 +4,6 @@ import zio.ZIOAspect._ import zio.metrics._ import zio.metrics.MetricKeyType.Histogram import zio.test._ -import zio.test.TestAspect._ import java.time.temporal.ChronoUnit