fix: Omit Empty Assertion Fields in Device Authorization Request #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
855adc0 to
46cabe4
Compare
muhlemmer
approved these changes
Jul 2, 2025
Collaborator
|
hey @jonyoder thanks for the contribution. If you'd like to have a small gift in return, please send us a mail to [email protected]. We will send you a form with questions about your address and shirt size. |
|
🎉 This PR is included in version 3.39.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
migregal
pushed a commit
to migregal/oidc
that referenced
this pull request
Jul 14, 2025
migregal
pushed a commit
to migregal/oidc
that referenced
this pull request
Jul 14, 2025
migregal
pushed a commit
to migregal/oidc
that referenced
this pull request
Jul 14, 2025
migregal
pushed a commit
to migregal/oidc
that referenced
this pull request
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to #744.
This adds the
omitemptyattribute to the client assertion fields used for device authorization. These fields are encoded as form values when calling thedevice/authorizeAPI. When these fields are empty and don't include theomitemptyattribute, they're being encoded as empty/blank values which can cause issues with some providers, e.g., Okta.Please let me know if there's anything else I can do to help. I didn't see any relevant unit tests to update.