fix: enable feature rustls-tls-native-roots in reqwest #1328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, it allows the usage of SSL_CERT_FILE which is useful e.g. in corporate environments Docs: https://docs.rs/reqwest/latest/reqwest/#tls
Contributor
Author
|
I've marked this as a But happy to treat as a feature 😄 |
3 tasks
Member
Fix make sense, thank you! |
woodruffw
reviewed
Nov 12, 2025
| owo-colors.workspace = true | ||
| regex.workspace = true | ||
| reqwest = { workspace = true, features = ["blocking", "json", "rustls-tls"] } | ||
| reqwest = { workspace = true, features = ["blocking", "json", "rustls-tls", "rustls-tls-native-roots"] } |
Member
There was a problem hiding this comment.
This seems fine, but noting: we'll probably want to use rustls-platform-verifier once available in reqwest.
woodruffw
approved these changes
Nov 12, 2025
Member
woodruffw
left a comment
There was a problem hiding this comment.
LGTM, thank you @carlosdagos!
Signed-off-by: William Woodruff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submission checks
Please check these boxes:
Mandatory: This PR corresponds to an issue (if not, please create
one first): Issue [BUG]: UnknownIssuer error when running audit behind TLS intercepting proxy #1327
I hereby disclose the use of an LLM or other AI coding assistant in the
creation of this PR. PRs will not be rejected for using AI tools, but
will be rejected for undisclosed use.
If a checkbox is not applicable, you can leave it unchecked.
Summary
Enables the feature in
reqwestto support (amongst other things) env varsSSL_CERT_DIRandSSL_CERT_FILE. This enables usage of zizmor behind TLS intercepting proxies.Test Plan
zizmoraccording to bug [BUG]: UnknownIssuer error when running audit behind TLS intercepting proxy #1327UnknownIssuer.