feat: add break statements for while loops #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add BREAK token type and keyword recognition in lexer - Implement parseBreakStatement() method in parser - Create BreakNode AST class with BreakException control flow - Enhance WhileStatementNode to handle break statements - Add comprehensive test suite with 7 test cases - Create example program demonstrating usage patterns - Update README.md with documentation and feature lists - Add files to CMakeLists.txt for compilation This enables early exit from while loops for search patterns, safety limits, and conditional processing while maintaining backward compatibility.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for the break statement in the O²L programming language, allowing early exit from while loops to enable search patterns, iteration limits, and more expressive control flow.
- Added complete
breakstatement implementation across lexer, parser, AST, and runtime - Integrated break statement handling in while loops using exception-based control flow
- Added comprehensive test coverage and example files demonstrating various break statement use cases
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/AST/BreakNode.hpp |
Defines the BreakNode AST class for representing break statements |
src/AST/BreakNode.cpp |
Implements BreakNode evaluation by throwing BreakException |
src/Common/Exceptions.hpp |
Adds BreakException for control flow handling |
src/AST/WhileStatementNode.cpp |
Updates while loop to catch and handle BreakException |
src/Lexer.hpp |
Adds BREAK token type to lexer |
src/Lexer.cpp |
Adds "break" keyword recognition |
src/Parser.hpp |
Declares parseBreakStatement method |
src/Parser.cpp |
Implements break statement parsing and AST integration |
tests/test_break_statement.cpp |
Comprehensive test suite for break statement functionality |
tests/CMakeLists.txt |
Registers break statement tests in build system |
examples/test_break_examples.obq |
Example file demonstrating various break statement patterns |
README.md |
Documents break statement feature with usage examples |
CMakeLists.txt |
Adds BreakNode source files to build configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the
breakstatement to the language, allowing early exit fromwhileloops. The implementation includes updates to the lexer, parser, AST, and runtime, as well as documentation and example/test coverage. This feature enables more expressive control flow, such as search patterns and iteration limits.Language Feature: Break Statement
breakstatement support for early exit fromwhileloops, including AST node (BreakNode), parser logic, and runtime handling via a dedicated exception (BreakException). [1] [2] [3] [4] [5] [6] [7] [8]Lexer and Parser Updates
breakas a keyword and added its token type. [1] [2]BreakNodeinto the parser and AST build process. [1] [2] [3] [4] [5] [6]Documentation and Examples
breakstatement inREADME.md, including usage, features, and example code snippets. [1] [2] [3] [4]examples/test_break_examples.obqdemonstrating various break statement scenarios.Testing