Add full param options for monitors #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ojongerius Hey, just wanted to follow up on this, now that we are through the holidays 😄 |
44e0c8c to
28b3af0
Compare
|
Hi there, any progress on this one? Could really use the feature. I'm happy to open a new PR with a rebased version if @Seanstoppable is not available. |
|
I'm happy to re-pick up this work |
Add a more generic function that will let people mix and match Have existing functions wrap this better function Resolves the rest of state support in zorkian#164
28b3af0 to
e0e1131
Compare
|
@chirauki rebased |
Closed
|
So cool! I guess someone will nned to take a look, approve and merge? @ojongerius maybe? |
platinummonkey
approved these changes
Sep 13, 2019
|
This looks awesome, thanks a bunch for doing it. Everything looks fine, so I'm going to merge right now. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a more generic function that will let people mix and match
Have existing functions wrap this better function
Resolves the rest of state support in #164