Thanks to visit codestin.com
Credit goes to github.com

Skip to content

AppendEvent() doesn't signal SIG_EVENT_PORT, Do_Signals wouldn't process it... #28

@hostilefork

Description

@hostilefork

Was going over some old unmerged pre-Ren/C bits on files.

I found that I had hit CureCode #1422 and noticed that Append_Event() wasn't doing anything to signal the events to be processed. The clients seemed to think it did. Then there was a smoking gun of a NOT_USED_INVESTIGATE in Do_Signals regarding the handling of said event.

This fairly minimal fix might take care of it:

https://github.com/metaeducation/ren-c/pull/116/files

I restored the EVENTS_LIMIT but added your chunking code in case someone needed an expanding event queue at some point.. So it's initialized to a smaller queue to force expansion, to keep that tested if it is needed.

In testing with the TCP port prober from #1422 I noticed that the output I got was different from with just the large queue. I got:

TCP-event lookup
port 1 is open
TCP-event lookup
port 2 is open
.
.
.
TCP-event lookup
port 200 is open

So it was printing this extra "TCP-event lookup" message, which comes from the "default awake handler". I do not know enough about what the schemes are supposed to do to know if that is good or bad. But what I did notice was that these lookup events were indeed pending, because if I ran a WAIT after running the scan in the large-queue-method they'd all come piling out and printing anyway.

In any case, submitted for your review.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions