Codestin Search App

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 179830043: code review 179830043: [release-branch.go1.4] remove cmd/link from nacl test zip (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by adg

Modified:
11 years, 3 months ago

Reviewers:
dsymonds

CC:
rsc, dsymonds, golang-codereviews

Visibility:
Public.

Description

[release-branch.go1.4] remove cmd/link from nacl test zip

Patch Set 1 #

Patch Set 2 : diff -r 0e2181d86f0b60e35254e0900d46154137147a9a https://code.google.com/p/go #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	misc/nacl/testzip.proto	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello rsc (cc: [email protected]), I'd like you to review this change to https://code.google.com/p/go

11 years, 3 months ago (2014-11-17 02:54:36 UTC) #1

dsymonds

I was also going to suggest removing it from the default branch too, since it ...

11 years, 3 months ago (2014-11-17 02:55:54 UTC) #3

adg

11 years, 3 months ago (2014-11-17 02:56:08 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=bffdd0cae380 ***

[release-branch.go1.4] remove cmd/link from nacl test zip

LGTM=dsymonds
R=rsc, dsymonds
CC=golang-codereviews
https://codereview.appspot.com/179830043

Expand All Messages | Collapse All Messages