[dotnet] options do not belong in the service class #12534
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## trunk #12534 +/- ##
=======================================
Coverage 57.26% 57.26%
=======================================
Files 86 86
Lines 5335 5335
Branches 198 198
=======================================
Hits 3055 3055
Misses 2082 2082
Partials 198 198 ☔ View full report in Codecov by Sentry. |
3778d9d to
2ec4ab5
Compare
|
@nvborisenko any .NET conventions to fix in my code? I kind of want to make all Driver location constructors in Driver classes obsolete since Selenium Manager should handle everything now (and there's the service class if it does not). |
4f2befe to
30963d5
Compare
Description
Follow Java approach and use Driver Finder in Driver constructor and not in the Service constructor.
Motivation and Context
If a user creates the service instance independently it will use DriverFinder for the default options instead of specified options. Generally not an issue since users have no reason to create a Service class in .NET if they aren't going to specify the location of the driver. But users need to be able to toggle things like logging without having options. and let DriverFinder still set location based on actual options.