BREAKING: remove cjs build & update min node to 20 #3687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
styfle
reviewed
May 21, 2025
styfle
reviewed
May 21, 2025
Member
There was a problem hiding this comment.
How was the performance here?
Curious if there is any difference between node versions.
Member
Author
There was a problem hiding this comment.
cjs was always slightly slower than esm. Not by much though.
styfle
approved these changes
May 21, 2025
Member
Author
|
I think this is ready to go, but I am going to wait to merge this for a month so we can bundle any other breaking changes together. |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 27, 2025
# [16.0.0](v15.0.12...v16.0.0) (2025-06-27) ### Bug Fixes * remove cjs build & update min node to 20 ([#3687](#3687)) ([0a35d8f](0a35d8f)) ### BREAKING CHANGES * - minify ./lib/marked.esm.js and ./lib/marked.umd.js - remove ./marked.min.js use ./lib/marked.umd.js instead - remove ./lib/marked.cjs - update minimum supported node version to 20 to support require('marked.esm.js'). see nodejs.org/docs/latest-v20.x/api/modules.html#loading-ecmascript-modules-using-require
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BREAKING CHANGES
./lib/marked.esm.jsand./lib/marked.umd.js./marked.min.jsuse./lib/marked.umd.jsinstead./lib/marked.cjsrequire('marked.esm.js'). see https://nodejs.org/docs/latest-v20.x/api/modules.html#loading-ecmascript-modules-using-requireContributor
Committer
In most cases, this should be a different person than the contributor.