Preserve snapshot names with INSTA_GLOB_FILTER #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `INSTA_GLOB_FILTER`, the common prefix used for snapshot naming should be derived from all files matching the original glob pattern, not just the filtered subset. This ensures that snapshot names retain their original file suffixes (e.g., `@file.txt.snap`) even when only a single file is matched by the filter. Adds a test case to verify this behavior. Co-authored-by: Claude <[email protected]>
2 tasks
max-sixty
added a commit
that referenced
this pull request
Sep 4, 2025
## Summary - Updates CHANGELOG.md to move all unreleased changes into the 1.43.2 section - Prepares for tagging version 1.43.2 ## Changes included in 1.43.2 - Fix panics when `cargo metadata` fails to execute or parse (#798) - Fix clippy `uninlined_format_args` lint warnings (#801) - Changed diff line numbers to 1-based indexing (#799) - Preserve snapshot names with `INSTA_GLOB_FILTER` (#786) - (Plus other changes already listed in the 1.43.2 section) ## Test plan - [x] CHANGELOG.md updated with all recent changes - [ ] Ready to tag as 1.43.2 after merge 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <[email protected]>
kkysen
added a commit
to immunant/c2rust
that referenced
this pull request
Sep 25, 2025
…ER` so that the snapshot file is correctly resolved (#1377) `INSTA_GLOB_FILTER` conveniently lets you run things like `INSTA_GLOB_FILTER=*/macros.c cargo test -p c2rust-transpile` to only test `macros.c`. However, previously, limiting the filter to a single snapshot messed up how the snapshot file path was calculated, resulting in a different snapshot (mitsuhiko/insta#785). Now this is fixed by mitsuhiko/insta#786, so this just updates to the latest `insta` version, which includes this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
INSTA_GLOB_FILTER, the common prefix used for snapshot naming should be derived from all files matching the original glob pattern, not just the filtered subset. This ensures that snapshot names retain their original file suffixes (e.g.,@file.txt.snap) even when only a single file is matched by the filter.Adds a test case to verify this behavior.
Co-authored-by: Claude [email protected]