Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@lepture
Copy link
Member

@lepture lepture commented Aug 8, 2025

According to #793, our previous fix doesn't work well. This is another fix.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

  • You consent that the copyright of your pull request source code belongs to Authlib's author.

@lepture lepture requested a review from azmeuk August 8, 2025 03:35
@lepture
Copy link
Member Author

lepture commented Aug 8, 2025

cc @kaorihinata @markhobson

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2025

@azmeuk
Copy link
Member

azmeuk commented Aug 8, 2025

Ah, actually we already had a MissingCodeException. I did not see that either...
At least #786 brought us that unit test, and it validates the fix here (the test fails if I disable your fix):
https://github.com/authlib/authlib/pull/786/files#diff-32309580fe6223cf33fe92fee41783e290868760c386af863839e13abcd6c551R530-R556

@azmeuk azmeuk added the bug label Aug 8, 2025
@lepture lepture merged commit c9890da into main Aug 9, 2025
18 checks passed
@lepture lepture deleted the fix-missing-code branch August 9, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants