fix: implemented cancel scenario in oauthSignIn for signInWithRedirect #14434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soberm
requested changes
Jul 24, 2025
packages/auth/__tests__/providers/cognito/signInWithRedirect.test.ts
Outdated
Show resolved
Hide resolved
packages/auth/__tests__/providers/cognito/signInWithRedirect.test.ts
Outdated
Show resolved
Hide resolved
…mplify-js into fix/cognito-signinwithredirect
Contributor
Author
|
@soberm Thank you for your review. I fixed the PR comments. Let me know if I need to do something else. |
Contributor
|
Hi @hetmann, currently the unit-tests fail. |
Contributor
|
Run the E2E tests here. |
soberm
approved these changes
Sep 8, 2025
sarayev
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR fixes the use case to handle when user cancels the pop up for federated Sign In when calling
signInWithRedirect().Issue #, if available
#9948
Description of how you validated changes
Run unit, E2E tests
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.