Create devcontainer for codespaces + update all dev dependencies #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggyhead
approved these changes
Jan 5, 2023
SrRyan
approved these changes
Jan 5, 2023
tdfacer
pushed a commit
to ifit/upload-artifact
that referenced
this pull request
Oct 7, 2025
…ions#375) * Create devcontainer for codespaces * Use node 16 for devcontainer and CI * Fix node version incompatibility error * Remove caching * Add npm build to check-dist * Remove new caching * use npm install * Test node 14 * Update check dist with node 16 * Use node 18.x for check-dist * Npm install vs CI * Update package.json scripts * test * Remove caching * npm run test * testing * test * test * One more test * Test * test * Update everything * use vercel * Test * Update index.js * Test * Remove codeql warnings * Use NPM CI vs install * Small tweaks to existing workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if you create a codespace is creates one with a really old node version and npm and that causes
package.jsonto drop down to version 1 and it messes up a bunch of things.I'm adding a basic devcontainer so that we have a basic node codespace that gets created. This makes it easier to to development and for small changes such as package updates.
In order to make node16 work in CI, we had to update all dev dependencies as well. This fixed something with NPM due to really old deprecated packages 🤷♂️
We also moved from
zeit/ncctovercel/nccwhich is supported and our other first party actions use this. Because of this we had to rebuildindex.jssubstantially