fix: update @adobe/eslint-config-helix to 3.0.12 with compatible lockfile #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file The Renovate bot updated package.json but generated a package-lock.json that is incompatible with npm 10.9.2 (used in CI with Node 22.14). The lockfile was missing the typescript peer dependency entry that npm 10.x expects. Regenerated the lockfile using npm 10.9.2 to ensure compatibility. Fixes the "Missing: [email protected] from lock file" error in CI. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Lars Trieloff <[email protected]>
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
Collaborator
|
Claude finished @trieloff's task —— View job PR Review Complete ✅Review Checklist:
📋 Code Review SummaryThis PR addresses a legitimate CI compatibility issue with npm lockfiles. The changes are minimal, focused, and appropriate for the stated problem. ✅ Strengths
🔍 Analysis by CategoryCode Quality & Best Practices
Security
Performance
Compatibility & Dependencies
📝 Minor Observations
🎯 Recommendation✅ APPROVE - This is a well-executed fix for a specific CI issue. The changes are minimal, targeted, and solve the stated problem without introducing any risks. The approach of regenerating the lockfile with the target npm version is the standard and recommended solution for this type of compatibility issue. |
|
adobe-bot
pushed a commit
that referenced
this pull request
Oct 17, 2025
## [2.13.4](v2.13.3...v2.13.4) (2025-10-17) ### Bug Fixes * specify Node.js 24.10.0 for Release job to meet semantic-release v25 requirements ([#310](#310)) ([1aa611b](1aa611b)) * specify Node.js versions to meet semantic-release v25 requirements ([5b58d09](5b58d09)) * update @adobe/eslint-config-helix to 3.0.12 with compatible lockfile ([#309](#309)) ([732e4d2](732e4d2)) * update semantic-release to v25 and node to 24.x for OIDC ([14dcc0f](14dcc0f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@adobe/eslint-config-helixfrom 3.0.11 to 3.0.12package-lock.jsonusing npm 10.9.2 for CI compatibilityProblem
The Renovate bot updated
package.jsonbut generated apackage-lock.jsonthat was incompatible with npm 10.9.2 (used in CI with Node.js 22.14). The lockfile was missing the[email protected]peer dependency entry that npm 10.x expects, causingnpm cito fail with:Solution
Regenerated the lockfile using npm 10.9.2 to ensure compatibility with the CI environment.
Test plan
npm cipasses with npm 10.9.2🤖 Generated with Claude Code
Test URL
https://trieloff-fix-npm-lockfile-sync--helix-rum-js--adobe.aem.live/test/static.html