[PR #10644/8c4e60b0 backport][3.11] Add benchmarks for streaming API #10645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Thank you for your contribution! --> ## What do these changes do? Add benchmarks for streaming API. I get asked all the time if someone should use `iter_chunked`, `iter_any`, or `iter_chunks`. Its nice to be able to point people at benchmarks, especially ones they can alter with their numbers and run locally. Unsurprisingly `memcpy` is where the performance issues are so avoiding it as much as possible will give better performance. In almost all cases `iter_chunks` is going to give the best performance if you can trust the chunk sizes aren't going to be too large. ## Are there changes in behavior for the user? no ## Is it a substantial burden for the maintainers to support this? no (cherry picked from commit 8c4e60b)
bdraco
approved these changes
Mar 31, 2025
CodSpeed Performance ReportMerging #10645 will not alter performanceComparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.11 #10645 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 126 126
Lines 37493 37577 +84
Branches 4525 4541 +16
=======================================
+ Hits 36779 36863 +84
Misses 538 538
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #10644 as merged into master (8c4e60b).
What do these changes do?
Add benchmarks for streaming API.
I get asked all the time if someone should use
iter_chunked,iter_any, oriter_chunks. Its nice to be able to point people at benchmarks, especially ones they can alter with their numbers and run locally.Unsurprisingly
memcpyis where the performance issues are so avoiding it as much as possible will give better performance. In almost all casesiter_chunksis going to give the best performance if you can trust the chunk sizes aren't going to be too large.Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no