Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sanxiyn
Copy link
Contributor

@sanxiyn sanxiyn commented Feb 19, 2024

Fix #10038.

@MichaReiser MichaReiser added the bug Something isn't working label Feb 19, 2024
@MichaReiser
Copy link
Member

Nice, thank you

@MichaReiser MichaReiser enabled auto-merge (squash) February 19, 2024 11:58
@MichaReiser MichaReiser merged commit 1c8851e into astral-sh:main Feb 19, 2024
@sanxiyn sanxiyn deleted the W293-fix branch February 19, 2024 11:59
nkxxll pushed a commit to nkxxll/ruff that referenced this pull request Mar 10, 2024
dylwil3 pushed a commit that referenced this pull request Jun 19, 2025
Part of #15584

This PR adds fix safety sections to `W291` and `W293`

The unsafe caveat was added in #10049


https://github.com/astral-sh/ruff/blob/10a1d9f01e899201c8d37d29071fe68752d09544/crates/ruff_linter/src/rules/pycodestyle/rules/trailing_whitespace.rs#L92

Code example demonstrating unsafety:
```
PS ~\Desktop\New_folder\ruff>Get-Content issue.py
```
```py
# W291
"""
1
"""

# W293
"""

"""
```
```
PS ~\Desktop\New_folder\ruff>Get-Escaped-Content issue.py
```
```
# W291\n"""\n1 \n"""\n\n# W293\n"""\n \n"""\r\n
```
```
PS ~\Desktop\New_folder\ruff>uvx ruff check issue.py --isolated --select W
```
```snap
issue.py:3:2: W291 Trailing whitespace
  |
1 | # W291
2 | """
3 | 1
  |  ^ W291
4 | """
  |
  = help: Remove trailing whitespace

issue.py:8:1: W293 Blank line contains whitespace
  |
6 | # W293
7 | """
8 |
  | ^ W293
9 | """
  |
  = help: Remove whitespace from blank line

Found 2 errors.
No fixes available (2 hidden fixes can be enabled with the `--unsafe-fixes` option).
```

## Test Plan

<!-- How was it tested? -->

N/A, no tests affected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(🐞) blank-line-with-whitespace (W293) fix is highly unsafe

2 participants