Correctly print parens around in in for heads
#16630
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57311 |
| inForStatementInit: boolean = false; | ||
| enterForStatementInit(val: boolean) { | ||
| const old = this.inForStatementInit; | ||
| if (old === val) return () => {}; |
There was a problem hiding this comment.
Maybe return undefined and then use exit?.() on the caller?
There was a problem hiding this comment.
Isn't it better to use consistent types, rather than having polymorphic functions? It's trivial for an engine to optimise an empty function call.
|
Interesting PR! I wanted to test it, but link from @babel-bot fails with:
|
|
CircleCI has been working weirdly in the past few days, thanks for noticing the problem -- I'll see if it something that we need to fix :) |
|
It seems that the CircleCI API no longer allows cross-domain. |
I really wanted to use
using, but we would need an assumption to avoid the try/catch when we know it's not necessary.