Ensure that requeueComputedKeyAndDecorators is available
#16695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolo-ribaudo
commented
Jul 29, 2024
| Q | A |
|---|---|
| Fixed Issues? | Fixes #16694 |
| Patch: Bug Fix? | |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
nicolo-ribaudo
commented
Jul 29, 2024
| if (typeof options.then === "function") { | ||
| // @ts-expect-error We use ?. in case options is a thenable | ||
| // but not a promise | ||
| // @ts-expect-error We use ?. in case options is a thenable but not a promise |
Member
Author
There was a problem hiding this comment.
This is just to trigger a babel/core release, as per #16694 (comment)
Contributor
There was a problem hiding this comment.
Lol, I have a dedicate PR for that purpose: #16696
JLHwung
approved these changes
Jul 29, 2024
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57525 |
Contributor
|
Hi @nicolo-ribaudo , when do you plant to release this? |
Contributor
Released in 7.25.2 |
This was referenced Aug 20, 2024
This was referenced Nov 10, 2024
This was referenced Nov 10, 2024
Open
Open
Open
This was referenced Nov 11, 2024
Open
This was referenced Nov 12, 2024
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.