Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(js_analyze): implement noTernary #8201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Netail merged 1 commit into from
Nov 21, 2025
Merged

feat(js_analyze): implement noTernary #8201

Netail merged 1 commit into from
Nov 21, 2025

Conversation

@Netail
Copy link
Member

@Netail Netail commented Nov 21, 2025

Summary

Implement Eslint's noTernary

Closes #8200

Test Plan

Docs

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025

🦋 Changeset detected

Latest commit: 4f2bf6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Nov 21, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 21, 2025 •
edited
Loading

Walkthrough

This pull request introduces a new nursery lint rule noTernary to the Biome JavaScript linter that disallows the use of the ternary operator. The change includes the rule implementation targeting conditional expressions, configuration options support, test coverage with both valid and invalid test cases demonstrating the rule's behaviour, and the necessary module exports.

Suggested labels

A-Project, A-Linter, L-JavaScript, A-Diagnostic

Suggested reviewers

  • dyc3
  • ematipico

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description directly references the ESLint rule being ported and links to the corresponding GitHub issue, clearly relating to the changeset.
Linked Issues check ✅ Passed The PR successfully implements the noTernary rule as requested in issue #8200, with proper rule declaration, test coverage, and options configuration [#8200].
Out of Scope Changes check ✅ Passed All changes are directly related to implementing the noTernary rule; no out-of-scope modifications detected.
Title check ✅ Passed The title 'feat(js_analyze): implement noTernary' accurately summarises the main change—adding a new linting rule to disallow ternary operators in JavaScript code.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

Comment @coderabbitai help to get the list of available commands and usage tips.

@Netail Netail changed the title feat(js_analyze): Implement noTernary feat(js_analyze): implement noTernary Nov 21, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 21, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8201 will not alter performance

Comparing Netail:feat/no-ternary (4f2bf6d) with main (23f7855)1

Summary

✅ 58 untouched
⏩ 95 skipped2

Footnotes

  1. No successful run was found on main (c738a1c) during the generation of this report, so 23f7855 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 95 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

ematipico
ematipico approved these changes Nov 21, 2025
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy :)

@Netail Netail added this pull request to the merge queue Nov 21, 2025
Merged via the queue into biomejs:main with commit cd2edd7 Nov 21, 2025
20 of 21 checks passed
@Netail Netail deleted the feat/no-ternary branch November 21, 2025 15:03
@github-actions github-actions bot mentioned this pull request Nov 21, 2025
Merged
ryan-m-walker pushed a commit to ryan-m-walker/biome that referenced this pull request Nov 23, 2025
@Netail @ryan-m-walker
feat(js_analyze): implement noTernary (biomejs#8201)
7b8c206
@github-actions github-actions bot mentioned this pull request Nov 25, 2025
Merged
l0ngvh pushed a commit to l0ngvh/biome that referenced this pull request Dec 21, 2025
@Netail @l0ngvh
feat(js_analyze): implement noTernary (biomejs#8201)
29f355a
@coderabbitai coderabbitai bot mentioned this pull request Dec 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

No one assigned

Labels

A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

📎 port no-ternary from eslint

2 participants

@Netail @ematipico