-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Closed
Labels
package:emojisquad:platformIssue to be handled by the Platform team.Issue to be handled by the Platform team.type:improvementThis issue reports a possible enhancement of an existing feature.This issue reports a possible enhancement of an existing feature.
Milestone
Description
π Provide a description of the improvement
The current implementation of the EMOJI_SUPPORT_LEVEL definition assumes that there are only two supported emoji version on a user machine:
- 16
- 15
Older operation systems like Windows 10 do not seem to support emoji 15, while they still can render some symbols (see #17988 and the related Slack thread)
ckeditor5/packages/ckeditor5-emoji/src/emojiutils.ts
Lines 24 to 31 in 26bf48f
| /** | |
| * A map representing an emoji and its release version. | |
| * It's used to identify a user's minimal supported emoji level. | |
| */ | |
| const EMOJI_SUPPORT_LEVEL = { | |
| 'π«©': 16, // Face with bags under eyes. | |
| 'π«¨': 15.1 // Shaking head. Although the version of emoji is 15, it is used to detect versions 15 and 15.1. | |
| }; |
Let's extend the EMOJI_SUPPORT_LEVEL definition by introducing more emojis in a particular Unicode version.
Our database CDN includes the following versions:
[
16,
15.1,
15,
14,
13.1,
13,
12.1,
12,
11,
5,
4,
3,
2,
1,
0.7,
0.6
]Definition of Done
- Minor within the same major can be merged into a single version, like we do with
15and15.1. - The map includes each version and an example emoji introduced in a particular version.
- Find usage of the
EMOJI_SUPPORT_LEVELvariable and consider simplifying the algorithm. - Verify results on different machines. Screenshots are welcome.
- VirtualBox could be helpful.
Metadata
Metadata
Assignees
Labels
package:emojisquad:platformIssue to be handled by the Platform team.Issue to be handled by the Platform team.type:improvementThis issue reports a possible enhancement of an existing feature.This issue reports a possible enhancement of an existing feature.