Merged
Conversation
Contributor
There was a problem hiding this comment.
Blocking issue: the non-JIT code path doesn't implement the same error suppression logic as the JIT path, which will cause test failures and incorrect runtime behavior when jitless mode is enabled.
This was referenced Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5495 #635 #1510
I don't love this API but it's the best we've got at the moment. This is 100% opt-in. The classic
.optional()will continue behaving as it always has.Trying to enable exact optionality via some kind of global config is too kludgey and footgunny, so it needed to be an explicit API.