Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: nodeTypeKey not being used in NodeEventGenerator #19631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nzakas merged 1 commit into from
Apr 17, 2025
Merged

fix: nodeTypeKey not being used in NodeEventGenerator #19631

nzakas merged 1 commit into from
Apr 17, 2025

Conversation

@StyleShit
Copy link
Contributor

@StyleShit StyleShit commented Apr 17, 2025

Closes #19630

@StyleShit StyleShit requested a review from a team as a code owner April 17, 2025 12:56
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Apr 17, 2025
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Apr 17, 2025
@github-actions github-actions bot added the core Relates to ESLint's core APIs and features label Apr 17, 2025
@netlify
Copy link

netlify bot commented Apr 17, 2025 •
edited
Loading

✅ Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 4588d6f
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6800fa74ca2c8b00088985c2

Omerisra6
Omerisra6 reviewed Apr 17, 2025
View reviewed changes
Copy link

@Omerisra6 Omerisra6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool labels Apr 17, 2025
@mdjermanovic mdjermanovic moved this from Needs Triage to Implementing in Triage Apr 17, 2025
mdjermanovic
mdjermanovic approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Would like @nzakas to verify before merging.

@mdjermanovic mdjermanovic moved this from Implementing to Second Review Needed in Triage Apr 17, 2025
nzakas
nzakas approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work.

@nzakas nzakas merged commit 910bd13 into eslint:main Apr 17, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nzakas nzakas nzakas approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

+1 more reviewer

@Omerisra6 Omerisra6 Omerisra6 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly contributor pool core Relates to ESLint's core APIs and features

Projects

Triage
Status: Complete

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: nodeTypeKey not being used in NodeEventGenerator

4 participants

@StyleShit @nzakas @mdjermanovic @Omerisra6