Core & UI: Improve createRelativeLink and getPageByHref for i18n usage

fuma-nama · fuma-nama · commit 7d78bc5bc411 · 2025-05-22T17:37:51.000+08:00
diff --git a/.changeset/tricky-singers-throw.md b/.changeset/tricky-singers-throw.md
@@ -0,0 +1,6 @@
+---
+'fumadocs-core': patch
+'fumadocs-ui': patch
+---
+
+Improve `createRelativeLink` and `getPageByHref` for i18n usage
diff --git a/packages/core/src/source/loader.ts b/packages/core/src/source/loader.ts
@@ -92,6 +92,8 @@ export interface LoaderOutput<Config extends LoaderConfig> {
   getPageByHref: (
     href: string,
     options?: {
+      language?: string;
+
       /**
        * resolve relative file paths in `href` from specified dirname, must be a virtual path.
        */
@@ -299,30 +301,26 @@ function createOutput(options: LoaderOptions): LoaderOutput<LoaderConfig> {
     set pageTree(v) {
       pageTree = v;
     },
-    getPageByHref(href, { dir = '' } = {}) {
-      const pages = Array.from(walker.pages.values());
+    getPageByHref(href, { dir = '', language } = {}) {
+      const pages = this.getPages(language);
       const [value, hash] = href.split('#', 2);
+      let target;
 
       if (
         value.startsWith('.') &&
         (value.endsWith('.md') || value.endsWith('.mdx'))
       ) {
         const hrefPath = joinPath(dir, value);
-        const target = pages.find((item) => item.file.path === hrefPath);
-
-        if (target)
-          return {
-            page: target,
-            hash,
-          };
+        target = pages.find((item) => item.file.path === hrefPath);
+      } else {
+        target = pages.find((item) => item.url === value);
       }
 
-      const target = pages.find((item) => item.url === value);
-      if (target)
-        return {
-          page: target,
-          hash,
-        };
+      if (!target) return;
+      return {
+        page: target,
+        hash,
+      };
     },
     getPages(language = options.i18n?.defaultLanguage ?? '') {
       const pages: Page[] = [];
diff --git a/packages/ui/src/mdx.server.tsx b/packages/ui/src/mdx.server.tsx
@@ -17,7 +17,10 @@ export function createRelativeLink(
   return async function RelativeLink({ href, ...props }) {
     // resolve relative href
     if (href && href.startsWith('.')) {
-      const target = source.getPageByHref(href, { dir: page.file.dirname });
+      const target = source.getPageByHref(href, {
+        dir: page.file.dirname,
+        language: page.locale,
+      });
 
       if (target) {
         href = target.hash
