Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@n1ckdm
Copy link
Contributor

@n1ckdm n1ckdm commented Nov 29, 2020

Fix inconcsistency between code and quoted output and add a comment to make it more obvious what the progress.update(..) method does.

make it more obvious to understand what this is doing
Match the console output to the code
@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 100.00%. Comparing base (1e43c6b) to head (abcf482).
Report is 219 commits behind head on master.

❗ Current head abcf482 differs from pull request most recent head 6f75088. Consider uploading reports for the commit 6f75088 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #199      +/-   ##
===========================================
+ Coverage   96.24%   100.00%   +3.75%     
===========================================
  Files         280       242      -38     
  Lines        5942      4508    -1434     
===========================================
- Hits         5719      4508    -1211     
+ Misses        223         0     -223     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@svlandeg svlandeg added the docs Improvements or additions to documentation label Apr 21, 2022
@svlandeg svlandeg added p3 and removed investigate labels Mar 6, 2024
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

I updated the PR to be in-sync with the latest from master and this now looks good to merge to me.

Apologies for the long delay in reviewing this!

@github-actions
Copy link
Contributor

πŸ“ Docs preview for commit 6f75088 at: https://fe336598.typertiangolo.pages.dev

@svlandeg svlandeg changed the title Minor updates to Progress Bar tutorial πŸ“ Update the to Progress Bar tutorial with correct output Apr 18, 2024
@svlandeg svlandeg changed the title πŸ“ Update the to Progress Bar tutorial with correct output πŸ“ Update the Progress Bar tutorial with correct output Apr 18, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

@tiangolo
Copy link
Member

Great, thank you, and thanks for the patience! 🍰

Thank you @svlandeg πŸ™‡

@tiangolo tiangolo merged commit 7e944ac into fastapi:master Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation p3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants