Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@cecia234
Copy link
Contributor

  • Added "no comma-dangle" rule on eslint config file
  • Ran npm run lint:fix to remove remaining trailing commas

I get an error from coverage threshold on tests for lib/server.js but, since it is happening on main branch too, I ignored the pre-commit hook. I can open a PR to add the missing test if needed.

Fixes: #6029

Checklist

add no-comma-dangle eslint rule
remove trailing commas
@github-actions github-actions bot added the typescript TypeScript related label Apr 20, 2025
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday gurgunday changed the title #6029 Add "no comma-dangle" rule to eslint config and remove trailing commas style: add "no comma-dangle" rule to eslint config and remove trailing commas Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Small changes or internal project maintenance typescript TypeScript related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eslint inconsistencies

4 participants