feat: prepare to use Promise.withResolvers #6232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
086a64c to
3e4d41c
Compare
3e4d41c to
549056f
Compare
jean-michelet
approved these changes
Jun 23, 2025
Member
jean-michelet
left a comment
There was a problem hiding this comment.
Looks nice, but there isn't much changes on the overall codebase.
Did you identify other use cases?
Member
Author
I don't think it should be a massive change to the codebase.
Currently, no time to investigate more. |
metcoder95
approved these changes
Jun 24, 2025
Signed-off-by: KaKa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #5603
Use
Promise.withResolversto reduce the needs of multiplenew Promise.It helps to flatten the code and remove unnecessary
Promise.race.Checklist
npm run testandnpm run benchmarkand the Code of conduct