Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(deps): update dependency bcryptjs to v3 - - package.json #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

fix(deps): update dependency bcryptjs to v3 - - package.json #920

merged 1 commit into from
Mar 3, 2025

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Feb 21, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
bcryptjs ^2.4.3 -> ^3.0.2 age adoption passing confidence

Release Notes

dcodeIO/bcrypt.js (bcryptjs)

v3.0.2

Compare Source

Bug fixes
  • Use upstream fix to emit interop helpers (28e5103)

v3.0.1

Compare Source

Bug fixes
  • Separate ESM and UMD type definitions (e7055ca)

v3.0.0

Compare Source

Breaking changes
  • Modernize project structure (2f45985)
    The project now exports an ECMAScript module by default, albeit with an UMD fallback, ships with types, the dist/ directory no longer exists in version control, and Closure Compiler externs have been removed.
  • Generate 2b hashes by default (d36bfb4)
    This library was not affected by the bug that led to incrementing the bcrypt version from 2a to 2b, but nowadays most implementations use 2b, including the native bcrypt binding, so this change aligns with them. Existing hashes will continue to work, but test logic that generates hashes and compares them literally might need to be updated to account for the new default.
Features
  • Add helper to check for password input length (d5656b3)
Other
  • Update publish workflow (2a9bea9)
  • Add note on using the ESM variant in the browser (e09eb9a)
  • Update types (58333a1)
  • Merge lint and test workflows (2e3b176)
  • Fix tests (ec02e8a)
  • Update legacy fallback to handle crypto dependency (9db275f)
  • Update lint workflow title (ac70ac5)
  • Adapt crypto module usage for ESM environments (574d690)
  • Format with prettier (e746547)
  • Rename default branch to 'main' (548559d)
  • Update description to mention TypeScript support (4977df0)
  • Add stale action for issues and PRs (a84d4e4)
  • Fix typo (c8c9c01)
  • Fix Node.js version in CI (1b54cc4)
Backlog from v2
  • Added externs to .npmignore (#​124) (7e2e93a)
    The npm package does not need externs as it is needed only for closure compiler. Added it in .npmignore since bcryptjs overrides global module and process in WebStorm IDE.
  • Make sure the bin script uses LF (684fac6)
  • Post-merge; Clean up a bit (b09f7f2)
  • Improve safeStringCompare using xor (#​77) (648482a)
  • Added bin entry (49a1d1a)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@github-actions
Copy link

github-actions bot commented Feb 21, 2025 •
edited
Loading

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
See the Details below.

License Issues

package.json

PackageVersionLicenseIssue Type
bcryptjs^3.0.2NullUnknown License
Allowed Licenses: MIT, MIT-0, Apache-2.0, BSD-3-Clause, BSD-3-Clause-Clear, ISC, BSD-2-Clause, Unlicense, CC0-1.0, 0BSD, X11, MPL-2.0, MPL-1.0, MPL-1.1, MPL-2.0, Zlib
Excluded from license check: pkg:npm/caniuse-lite

OpenSSF Scorecard

PackageVersionScoreDetails
npm/bcryptjs 3.0.2 🟢 4.6
Details
CheckScoreReason
Maintained🟢 1019 commit(s) and 2 issue activity found in the last 90 days -- score normalized to 10
Packaging⚠️ -1packaging workflow not detected
Binary-Artifacts🟢 10no binaries found in the repo
Code-Review⚠️ 1Found 4/29 approved changesets -- score normalized to 1
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Fuzzing⚠️ 0project is not fuzzed
Security-Policy⚠️ 0security policy file not detected
License🟢 9license file detected
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Signed-Releases⚠️ -1no releases found
Vulnerabilities🟢 100 existing vulnerabilities detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
npm/bcryptjs ^3.0.2 🟢 4.6
Details
CheckScoreReason
Maintained🟢 1019 commit(s) and 2 issue activity found in the last 90 days -- score normalized to 10
Packaging⚠️ -1packaging workflow not detected
Binary-Artifacts🟢 10no binaries found in the repo
Code-Review⚠️ 1Found 4/29 approved changesets -- score normalized to 1
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Fuzzing⚠️ 0project is not fuzzed
Security-Policy⚠️ 0security policy file not detected
License🟢 9license file detected
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Signed-Releases⚠️ -1no releases found
Vulnerabilities🟢 100 existing vulnerabilities detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0

Scanned Files

  • package-lock.json
  • package.json

@github-actions github-actions bot added the fix label Feb 21, 2025
@netlify
Copy link

netlify bot commented Feb 21, 2025 •
edited
Loading

✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 3e15f09
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/67c089f38923490008eab245

@codecov
Copy link

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.20%. Comparing base (9811ac3) to head (3e15f09).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #920   +/-   ##
=======================================
  Coverage   63.20%   63.20%           
=======================================
  Files          47       47           
  Lines        1685     1685           
=======================================
  Hits         1065     1065           
  Misses        620      620

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot force-pushed the renovate/major-3-npm branch 7 times, most recently from 245ccd5 to 45cbde1 Compare February 23, 2025 23:30
@renovate renovate bot force-pushed the renovate/major-3-npm branch from 45cbde1 to 3e15f09 Compare February 27, 2025 15:51
@JamieSlome
Copy link
Member

JamieSlome commented Feb 28, 2025

@06kellyjac - can we get a review on this? Any adjustments to API that are potentially problematic with existing usage in the library?

@06kellyjac
Copy link
Contributor

06kellyjac commented Feb 28, 2025

The breaking changes were:

  • Now ECMAScript module

    • The project now exports an ECMAScript module by default, albeit with an UMD fallback, ships with types, the dist/ directory no longer exists in version control, and Closure Compiler externs have been removed.

    • With the fallback + the fact that our CI has all passed I think this is fine
  • Generate 2b hashes by default

    • Existing hashes will continue to work, but test logic that generates hashes and compares them literally might need to be updated to account for the new default.

    • CI has passed so maybe fine. I'll probably take a scan over the code. Maybe spin up git-proxy with existing users, then update lib and test.

renovate bot says it's pretty new so we could also just hold off a few days to see if anything else explodes upstream.
x.x.1 and x.x.2 had a couple little fixes for the importing, otherwise is looking good

@06kellyjac
Copy link
Contributor

06kellyjac commented Mar 3, 2025

Ran git-proxy prior to this end set up a user, logged in, logged out.

login

my-account

logout

logged-out

Switched to this PR, installed the new deps, and restarted git-proxy
Successfully logged in and logged out

login-after

image

@JamieSlome JamieSlome merged commit defcff1 into main Mar 3, 2025
14 checks passed
@JamieSlome JamieSlome deleted the renovate/major-3-npm branch March 3, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@06kellyjac 06kellyjac 06kellyjac approved these changes

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JamieSlome @06kellyjac