Correct buildServiceAccount vs buildServiceAgent #6951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b45242f to
325ab8d
Compare
inlined
approved these changes
Apr 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6951 +/- ##
=========================================
Coverage ? 54.79%
=========================================
Files ? 359
Lines ? 25059
Branches ? 5166
=========================================
Hits ? 13732
Misses ? 10090
Partials ? 1237 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Swapping around the naming as they are currently named incorrectly.
Service Agent is of the format:
[email protected]Service Account is of the format:
[PROJECT_NUMBER]@cloudbuild.gserviceaccount.comWe can validate this by looking at the accounts that are used during cloud build and run respectively.